Re: [PATCH 08/19] xfs: verify inode buffers as they are read from disk

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 08/19] xfs: verify inode buffers as they are read from disk
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Thu, 11 Oct 2012 17:45:56 -0400
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1349754670-32009-9-git-send-email-david@xxxxxxxxxxxxx>
References:	<1349754670-32009-1-git-send-email-david@xxxxxxxxxxxxx> <1349754670-32009-9-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

> +             if (unlikely(XFS_TEST_ERROR(!di_ok, mp,
> +                                             XFS_ERRTAG_ITOBP_INOTOBP,
> +                                             XFS_RANDOM_ITOBP_INOTOBP))) {
> +                     xfs_buf_ioerror(bp, EFSCORRUPTED);
> +                     XFS_CORRUPTION_ERROR(__func__, XFS_ERRLEVEL_HIGH,
> +                                          mp, dip);
> +#ifdef DEBUG
> +                     xfs_emerg(mp,
> +                             "bad inode magic/vsn daddr %lld #%d (magic=%x)",
> +                             (unsigned long long)bp->b_bn, i,
> +                             be16_to_cpu(dip->di_magic));
> +                     ASSERT(0);
> +#endif

Is there any point in having this additional output in addition to the
high error level corruption report above?

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 05/19] xfs: verify AGF blocks as they are read from disk, (continued) [PATCH 05/19] xfs: verify AGF blocks as they are read from disk, Dave Chinner Re: [PATCH 05/19] xfs: verify AGF blocks as they are read from disk, Christoph Hellwig [PATCH 06/19] xfs: verify AGI blocks as they are read from disk, Dave Chinner Re: [PATCH 06/19] xfs: verify AGI blocks as they are read from disk, Christoph Hellwig [PATCH 02/19] xfs: make buffer read verication an IO completion function, Dave Chinner Re: [PATCH 02/19] xfs: make buffer read verication an IO completion function, Christoph Hellwig [PATCH 04/19] xfs: verify superblocks as they are read from disk, Dave Chinner Re: [PATCH 04/19] xfs: verify superblocks as they are read from disk, Christoph Hellwig Re: [PATCH 04/19] xfs: verify superblocks as they are read from disk, Dave Chinner [PATCH 08/19] xfs: verify inode buffers as they are read from disk, Dave Chinner Re: [PATCH 08/19] xfs: verify inode buffers as they are read from disk, Christoph Hellwig <= Re: [PATCH 08/19] xfs: verify inode buffers as they are read from disk, Dave Chinner [PATCH 14/19] xfs: factor dir2 free block reading, Dave Chinner [PATCH 03/19] xfs: uncached buffer reads need to return an error, Dave Chinner Re: [PATCH 03/19] xfs: uncached buffer reads need to return an error, Christoph Hellwig Re: [PATCH 03/19] xfs: uncached buffer reads need to return an error, Dave Chinner Re: [PATCH 03/19] xfs: uncached buffer reads need to return an error, Dave Chinner [PATCH 07/19] xfs: verify AGFL blocks as they are read from disk, Dave Chinner Re: [PATCH 07/19] xfs: verify AGFL blocks as they are read from disk, Christoph Hellwig Re: [PATCH 07/19] xfs: verify AGFL blocks as they are read from disk, Dave Chinner [PATCH 10/19] xfs: verify dquot blocks as they are read from disk, Dave Chinner

Previous by Date:	Re: [PATCH 07/19] xfs: verify AGFL blocks as they are read from disk, Christoph Hellwig
Next by Date:	Re: [PATCH 10/19] xfs: verify dquot blocks as they are read from disk, Christoph Hellwig
Previous by Thread:	[PATCH 08/19] xfs: verify inode buffers as they are read from disk, Dave Chinner
Next by Thread:	Re: [PATCH 08/19] xfs: verify inode buffers as they are read from disk, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]