| To: | Eric Sandeen <sandeen@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/2] xfs_io: include headers for preadv/pwritev |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Wed, 10 Oct 2012 09:21:30 +1100 |
| Cc: | xfs-oss <xfs@xxxxxxxxxxx> |
| In-reply-to: | <50749EE2.6070408@xxxxxxxxxx> |
| References: | <50749EE2.6070408@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Oct 09, 2012 at 05:02:10PM -0500, Eric Sandeen wrote: > We need to include uio.h to avoid: > > [CC] pread.o > pread.c: In function ‘do_pread’: > pread.c:198: warning: implicit declaration of function ‘preadv’ > [CC] pwrite.o > pwrite.c: In function ‘do_pwrite’: > pwrite.c:85: warning: implicit declaration of function ‘pwritev’ Funny, I don't recall ever seeing that error when I wrote these patches. But, yeah, I see them now. > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 2/2] xfs_io: configure tests for preadv/pwritev & sync_file_range, Eric Sandeen |
|---|---|
| Next by Date: | Re: [PATCH 06/14] xfs: xfs_sync_data is redundant., Brian Foster |
| Previous by Thread: | Re: [PATCH 2/2 V2] xfs_io: configure tests for preadv/pwritev & sync_file_range, Dave Chinner |
| Next by Thread: | [PATCH 1/2 V2] xfs_io: include headers for preadv/pwritev, Eric Sandeen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |