Re: [patch v4 04/13] [PATCH 04/13] xfs: sync work is now only periodic l

To:	Ben Myers <bpm@xxxxxxx>
Subject:	Re: [patch v4 04/13] [PATCH 04/13] xfs: sync work is now only periodic log work
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Fri, 5 Oct 2012 14:16:45 -0400
Cc:	Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, Dave Chinner <dchinner@xxxxxxxxxx>
In-reply-to:	<20121005171945.888412779@xxxxxxx>
References:	<20121005171853.985930109@xxxxxxx> <20121005171945.888412779@xxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Fri, Oct 05, 2012 at 12:18:57PM -0500, Ben Myers wrote:
>               ASSERT(mp->m_flags & XFS_MOUNT_RDONLY);
>       }
>  
> +     xfs_log_work_queue(mp);
> +
>       return error;

I still think queueing the work item here if we return a failure is
the wrong thing to do.

<Prev in Thread]	Current Thread	[Next in Thread>
[patch v4 00/13] xfs: remove the xfssyncd mess, Ben Myers [patch v4 06/13] [PATCH 06/13] xfs: xfs_sync_data is redundant., Ben Myers Re: [patch v4 06/13] [PATCH 06/13] xfs: xfs_sync_data is redundant., Mark Tinguely Re: [patch v4 06/13] [PATCH 06/13] xfs: xfs_sync_data is redundant., Ben Myers Re: [patch v4 06/13] [PATCH 06/13] xfs: xfs_sync_data is redundant., Christoph Hellwig Re: [patch v4 06/13] [PATCH 06/13] xfs: xfs_sync_data is redundant., Mark Tinguely [patch v4 04/13] [PATCH 04/13] xfs: sync work is now only periodic log work, Ben Myers Re: [patch v4 04/13] [PATCH 04/13] xfs: sync work is now only periodic log work, Christoph Hellwig <= Re: [patch v4 04/13] [PATCH 04/13] xfs: sync work is now only periodic log work, Mark Tinguely [patch v4 07/13] [PATCH 07/13] xfs: syncd workqueue is no more, Ben Myers Re: [patch v4 07/13] [PATCH 07/13] xfs: syncd workqueue is no more, Mark Tinguely [patch v4 08/13] [PATCH 08/13] xfs: xfs_sync_fsdata is redundant, Ben Myers [patch v4 10/13] [PATCH 10/13] xfs: xfs_quiesce_attr() should quiesce the log like, Ben Myers [patch v4 05/13] [PATCH 05/13] xfs: Bring some sanity to log unmounting, Ben Myers [patch v4 09/13] [PATCH 09/13] xfs: move xfs_quiesce_attr() into xfs_super.c, Ben Myers [patch v4 11/13] [PATCH 11/13] xfs: rename xfs_sync.[ch] to xfs_icache.[ch], Ben Myers [patch v4 02/13] [PATCH 02/13] xfs: rationalise xfs_mount_wq users, Ben Myers [patch v4 03/13] [PATCH 03/13] xfs: dont run the sync work if the filesystem is, Ben Myers

Previous by Date:	Re: [patch v4 06/13] [PATCH 06/13] xfs: xfs_sync_data is redundant., Mark Tinguely
Next by Date:	Re: [patch v4 04/13] [PATCH 04/13] xfs: sync work is now only periodic log work, Mark Tinguely
Previous by Thread:	[patch v4 04/13] [PATCH 04/13] xfs: sync work is now only periodic log work, Ben Myers
Next by Thread:	Re: [patch v4 04/13] [PATCH 04/13] xfs: sync work is now only periodic log work, Mark Tinguely
Indexes:	[Date] [Thread] [Top] [All Lists]