Re: [patch v4 06/13] [PATCH 06/13] xfs: xfs_sync

To:	Ben Myers <bpm@xxxxxxx>
Subject:	Re: [patch v4 06/13] [PATCH 06/13] xfs: xfs_sync_data is redundant.
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Fri, 5 Oct 2012 14:15:43 -0400
Cc:	Mark Tinguely <tinguely@xxxxxxx>, Dave Chinner <dchinner@xxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to:	<20121005180446.GN25175@xxxxxxx>
References:	<20121005171853.985930109@xxxxxxx> <20121005171946.330155632@xxxxxxx> <506F1F21.6000104@xxxxxxx> <20121005180446.GN25175@xxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Fri, Oct 05, 2012 at 01:04:46PM -0500, Ben Myers wrote:
> Christoph suggested that xfs_flush_inodes should take an xfs_mount instead of
> an inode.  It is operating on the super_block level to flush multiple inodes
> rather than the single inode whose pointer was passed in, so I moved it from
> xfs_inode.h to xfs_mount.h.

It's more than a trivial wrapper now, so I'd suggest to move out of line
to e.g. xfs_super.c

<Prev in Thread]	Current Thread	[Next in Thread>
[patch v4 00/13] xfs: remove the xfssyncd mess, Ben Myers [patch v4 06/13] [PATCH 06/13] xfs: xfs_sync_data is redundant., Ben Myers Re: [patch v4 06/13] [PATCH 06/13] xfs: xfs_sync_data is redundant., Mark Tinguely Re: [patch v4 06/13] [PATCH 06/13] xfs: xfs_sync_data is redundant., Ben Myers Re: [patch v4 06/13] [PATCH 06/13] xfs: xfs_sync_data is redundant., Christoph Hellwig <= Re: [patch v4 06/13] [PATCH 06/13] xfs: xfs_sync_data is redundant., Mark Tinguely [patch v4 04/13] [PATCH 04/13] xfs: sync work is now only periodic log work, Ben Myers Re: [patch v4 04/13] [PATCH 04/13] xfs: sync work is now only periodic log work, Christoph Hellwig Re: [patch v4 04/13] [PATCH 04/13] xfs: sync work is now only periodic log work, Mark Tinguely [patch v4 07/13] [PATCH 07/13] xfs: syncd workqueue is no more, Ben Myers Re: [patch v4 07/13] [PATCH 07/13] xfs: syncd workqueue is no more, Mark Tinguely [patch v4 08/13] [PATCH 08/13] xfs: xfs_sync_fsdata is redundant, Ben Myers [patch v4 10/13] [PATCH 10/13] xfs: xfs_quiesce_attr() should quiesce the log like, Ben Myers [patch v4 05/13] [PATCH 05/13] xfs: Bring some sanity to log unmounting, Ben Myers [patch v4 09/13] [PATCH 09/13] xfs: move xfs_quiesce_attr() into xfs_super.c, Ben Myers

Previous by Date:	Re: [patch v4 06/13] [PATCH 06/13] xfs: xfs_sync_data is redundant., Ben Myers
Next by Date:	Re: [patch v4 06/13] [PATCH 06/13] xfs: xfs_sync_data is redundant., Mark Tinguely
Previous by Thread:	Re: [patch v4 06/13] [PATCH 06/13] xfs: xfs_sync_data is redundant., Ben Myers
Next by Thread:	Re: [patch v4 06/13] [PATCH 06/13] xfs: xfs_sync_data is redundant., Mark Tinguely
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [patch v4 06/13] [PATCH 06/13] xfs: xfs_sync_data is redundant.