| To: | Linda Walsh <xfs@xxxxxxxxx> |
|---|---|
| Subject: | Re: Why xfs_<utils> not 'readline' w/line-edit & history enabled? (+attachment) |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Wed, 3 Oct 2012 09:14:00 +1000 |
| Cc: | xfs-oss <xfs@xxxxxxxxxxx> |
| In-reply-to: | <506B7018.7040000@xxxxxxxxx> |
| References: | <506B1A03.7030600@xxxxxxxxx> <20121002201748.GQ23520@dastard> <506B5DE1.4020000@xxxxxxxxx> <20121002215253.GT23520@dastard> <506B7018.7040000@xxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Oct 02, 2012 at 03:52:08PM -0700, Linda Walsh wrote: > Dave Chinner wrote: > >Patches welcome. > > > >Cheers, > > > >Dave. > --- > Gee, that's a hard one... (build and tested that it was included)... Actually, it's a lot more than just changing the default. If the build system doesn't have libreadline/libedit/libtermcap installed, the build will fail. You need to add detection of the libraries' presence on the build system, and then the "--enable-*" options can go away entirely. See, for example, the way libuuid is detected in m4/package_uuiddev.m4.... Also, libedit is only supposed to be used as a fallback option if libreadline is not available. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| Previous by Date: | Re: Why xfs_<utils> not 'readline' w/line-edit & history enabled? (+attachment), Linda Walsh |
|---|---|
| Next by Date: | Re: Why xfs_<utils> not 'readline' w/line-edit & history enabled? (+attachment), Linda Walsh |
| Previous by Thread: | Re: Why xfs_<utils> not 'readline' w/line-edit & history enabled? (+attachment), Linda Walsh |
| Next by Thread: | Re: Why xfs_<utils> not 'readline' w/line-edit & history enabled? (+attachment), Linda Walsh |
| Indexes: | [Date] [Thread] [Top] [All Lists] |