Re: [PATCH 06/13] xfs: xfs_sync

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 06/13] xfs: xfs_sync_data is redundant.
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Fri, 28 Sep 2012 08:34:43 -0400
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1348807485-20165-7-git-send-email-david@xxxxxxxxxxxxx>
References:	<1348807485-20165-1-git-send-email-david@xxxxxxxxxxxxx> <1348807485-20165-7-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

>  /*
> + * Flush all dirty data to disk. Must not be called while holding an 
> XFS_ILOCK

slightly too long line.

> + * or a page lock.
> + */
> +static inline void
> +xfs_flush_inodes(struct xfs_inode *ip)
> +{
> +     writeback_inodes_sb_if_idle(VFS_I(ip)->i_sb, WB_REASON_FS_FREE_SPACE);
> +}

Passing an inode here seems very odd, an xfs_mount would be the proper
interface. 

Looks fine modulo these cosmetic changes, so:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH V3 00/13] xfs: remove the xfssyncd mess, Dave Chinner [PATCH 02/13] xfs: rationalise xfs_mount_wq users, Dave Chinner Re: [PATCH 02/13] xfs: rationalise xfs_mount_wq users, Christoph Hellwig [PATCH 01/13] xfs: xfs_syncd_stop must die, Dave Chinner [PATCH 03/13] xfs: don't run the sync work if the filesystem is read-only, Dave Chinner Re: [PATCH 03/13] xfs: don't run the sync work if the filesystem is read-only, Christoph Hellwig [PATCH 04/13] xfs: sync work is now only periodic log work, Dave Chinner Re: [PATCH 04/13] xfs: sync work is now only periodic log work, Christoph Hellwig [PATCH 05/13] xfs: Bring some sanity to log unmounting, Dave Chinner [PATCH 06/13] xfs: xfs_sync_data is redundant., Dave Chinner Re: [PATCH 06/13] xfs: xfs_sync_data is redundant., Christoph Hellwig <= Re: [PATCH 06/13] xfs: xfs_sync_data is redundant., Mark Tinguely [PATCH 08/13] xfs: xfs_sync_fsdata is redundant, Dave Chinner [PATCH 07/13] xfs: syncd workqueue is no more, Dave Chinner Re: [PATCH 07/13] xfs: syncd workqueue is no more, Christoph Hellwig Re: [PATCH 07/13] xfs: syncd workqueue is no more, Mark Tinguely [PATCH 10/13] xfs: xfs_quiesce_attr() should quiesce the log like unmount, Dave Chinner [PATCH 09/13] xfs: move xfs_quiesce_attr() into xfs_super.c, Dave Chinner [PATCH 12/13] xfs: move inode locking functions to xfs_inode.c, Dave Chinner [PATCH 11/13] xfs: rename xfs_sync.[ch] to xfs_icache.[ch], Dave Chinner [PATCH 13/13] xfs: remove xfs_iget.c, Dave Chinner

Previous by Date:	Re: [PATCH 04/13] xfs: sync work is now only periodic log work, Christoph Hellwig
Next by Date:	Re: [PATCH 07/13] xfs: syncd workqueue is no more, Christoph Hellwig
Previous by Thread:	[PATCH 06/13] xfs: xfs_sync_data is redundant., Dave Chinner
Next by Thread:	Re: [PATCH 06/13] xfs: xfs_sync_data is redundant., Mark Tinguely
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [PATCH 06/13] xfs: xfs_sync_data is redundant.