| To: | Mark Tinguely <tinguely@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH v2] xfsprog: remove duplicate vector memalign from xfs_io |
| From: | Ben Myers <bpm@xxxxxxx> |
| Date: | Thu, 27 Sep 2012 10:05:42 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20120927124742.695778439@xxxxxxx> |
| References: | <20120925142414.660506845@xxxxxxx> <20120925142421.398175185@xxxxxxx> <20120926220434.GG13214@xxxxxxx> <20120927124742.695778439@xxxxxxx> |
| User-agent: | Mutt/1.5.20 (2009-06-14) |
On Thu, Sep 27, 2012 at 07:47:36AM -0500, Mark Tinguely wrote: > The vector feature of xfs_io uses its own memory buffer in the iov structure > and does not use the buffer entry. Remove the duplicate memalign. > > v2: removed global buffer in __dump_buffer() and use passed buf pointer per > Ben's detection. > > Signed-off-by: Mark Tinguely <tinguely@xxxxxxx> > Reviewed-by: Ben Myers <bpm@xxxxxxx> Still looks good. Don't forget to update the subject to xfsprogs. Also the line width looks like it might wrap. -Ben |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfsprog: remove duplicate vector memalign from xfs_io, Ben Myers |
|---|---|
| Next by Date: | Re: more efficient way to print out inode->block mappings?, Ben Myers |
| Previous by Thread: | [PATCH v2] xfsprog: remove duplicate vector memalign from xfs_io, Mark Tinguely |
| Next by Thread: | Re: [PATCH v2] xfsprog: remove duplicate vector memalign from xfs_io, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |