Re: [PATCH 1/3] xfs: restrict allocate worker to x86_64

[Dave Chinner <david@xxxxxxxxxxxxx>]

On Wed, Sep 19, 2012 at 11:31:34AM -0500, tinguely@xxxxxxx wrote:
> Restrict the allocation worker to X86_64 machines. This will improve
> performance on non-X86-64 machines and avoid the AGF buffer hang.
> 
> Signed-off-by: Mark Tinguely <tinguely@xxxxxxx>

NACK.

The stack overflow problems that this works around are not limited
to x86-64. In the past we've seen overflows on i686 (even with 8k
stacks), s390 and other platforms, so it's not an isolated issue.

It either works or it doesn't - let's not start down the rathole of
having different code paths and behaviours for different platforms.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx