Re: [PATCH v4] xfs: check for possible overflow in xfs_ioc

xfs

Re: [PATCH v4] xfs: check for possible overflow in xfs_ioc_trim

To:	Tomas Racek <tracek@xxxxxxxxxx>
Subject:	Re: [PATCH v4] xfs: check for possible overflow in xfs_ioc_trim
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Wed, 15 Aug 2012 07:36:29 +1000
Cc:	xfs@xxxxxxxxxxx, lczerner@xxxxxxxxxx
In-reply-to:	<1344933304-16014-1-git-send-email-tracek@xxxxxxxxxx>
References:	<1344933304-16014-1-git-send-email-tracek@xxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Tue, Aug 14, 2012 at 10:35:04AM +0200, Tomas Racek wrote:
> If range.start or range.minlen is bigger than filesystem size, return
> invalid value error. This fixes possible overflow in BTOBB macro when
> passed value was nearly ULLONG_MAX.
> 
> Signed-off-by: Tomas Racek <tracek@xxxxxxxxxx>

looks ok to me.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
-- 
Dave Chinner
david@xxxxxxxxxxxxx

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH v4] xfs: check for possible overflow in xfs_ioc_trim, Tomas Racek Re: [PATCH v4] xfs: check for possible overflow in xfs_ioc_trim, Dave Chinner <= Re: [PATCH v4] xfs: check for possible overflow in xfs_ioc_trim, Tomas Racek Re: [PATCH v4] xfs: check for possible overflow in xfs_ioc_trim, Ben Myers

Previous by Date:	Re: aborted SCSI commands while discarding/unmapping via mkfs.xfs, Dave Chinner
Next by Date:	Re: [PATCH v2] xfstests: Use upstream version of fstrim instead of the local one, Dave Chinner
Previous by Thread:	[PATCH v4] xfs: check for possible overflow in xfs_ioc_trim, Tomas Racek
Next by Thread:	Re: [PATCH v4] xfs: check for possible overflow in xfs_ioc_trim, Tomas Racek
Indexes:	[Date] [Thread] [Top] [All Lists]