| To: | Jeff Liu <jeff.liu@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH v6 1/4] xfs: Remove type argument from xfs_seek_data()/xfs_seek_hole() |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Fri, 10 Aug 2012 09:15:30 +1000 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <501B6B62.7040303@xxxxxxxxxx> |
| References: | <501B6B62.7040303@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Fri, Aug 03, 2012 at 02:10:42PM +0800, Jeff Liu wrote: > The type is already indicated by the function naming explicitly, so this > argument > can be omitted from those calls. > > Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx> Looks good. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfs: fix race while discarding buffers [V3], Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH v6 2/4] xfs: Introduce a new function to find the desired type of offset from page cache, Dave Chinner |
| Previous by Thread: | Re: [PATCH v6 1/4] xfs: Remove type argument from xfs_seek_data()/xfs_seek_hole(), Mark Tinguely |
| Next by Thread: | [PATCH v6 0/4] xfs: seek_data/seek_hole refinements, Jeff Liu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |