Re: [PATCH 9/9] xfs: factor buffer reading from xfs_dir2_leaf

xfs

Re: [PATCH 9/9] xfs: factor buffer reading from xfs_dir2_leaf_getdents

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 9/9] xfs: factor buffer reading from xfs_dir2_leaf_getdents
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Tue, 26 Jun 2012 06:16:43 -0400
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1340355015-26250-10-git-send-email-david@xxxxxxxxxxxxx>
References:	<1340355015-26250-1-git-send-email-david@xxxxxxxxxxxxx> <1340355015-26250-10-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Fri, Jun 22, 2012 at 06:50:15PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The buffer reading code in xfs_dir2_leaf_getdents is complex and difficult to
> follow due to the readahead and all the context is carries. it is also badly
> indented and so difficult to read. Factor it out into a separate function to
> make it easier to understand and optimise in future patches.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 2/9] xfs: separate buffer indexing from block map, (continued) Re: [PATCH 2/9] xfs: separate buffer indexing from block map, Christoph Hellwig [PATCH 5/9] xfs: add discontiguous buffer support to transactions, Dave Chinner [PATCH 1/9] xfs: struct xfs_buf_log_format isn't variable sized., Dave Chinner Re: [PATCH 1/9] xfs: struct xfs_buf_log_format isn't variable sized., Christoph Hellwig [PATCH 3/9] xfs: convert internal buffer functions to pass maps, Dave Chinner Re: [PATCH 3/9] xfs: convert internal buffer functions to pass maps, Christoph Hellwig [PATCH 4/9] xfs: add discontiguous buffer map interface, Dave Chinner [PATCH 6/9] xfs: support discontiguous buffers in the xfs_buf_log_item, Dave Chinner [PATCH 7/9] xfs: use discontiguous xfs_buf support in dabuf wrappers, Dave Chinner [PATCH 9/9] xfs: factor buffer reading from xfs_dir2_leaf_getdents, Dave Chinner Re: [PATCH 9/9] xfs: factor buffer reading from xfs_dir2_leaf_getdents, Christoph Hellwig <= [PATCH 8/9] xfs: remove struct xfs_dabuf and infrastructure, Dave Chinner

Previous by Date:	Re: [PATCH 3/9] xfs: convert internal buffer functions to pass maps, Christoph Hellwig
Next by Date:	[PATCH] xfs: Fix comment typo of xfs_open_devices(), Chen Baozi
Previous by Thread:	[PATCH 9/9] xfs: factor buffer reading from xfs_dir2_leaf_getdents, Dave Chinner
Next by Thread:	[PATCH 8/9] xfs: remove struct xfs_dabuf and infrastructure, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]