Re: [PATCH 3/9] xfs: add discontiguous buffer map interface

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 3/9] xfs: add discontiguous buffer map interface
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Wed, 20 Jun 2012 02:53:23 -0400
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1339133914-11148-4-git-send-email-david@xxxxxxxxxxxxx>
References:	<1339133914-11148-1-git-send-email-david@xxxxxxxxxxxxx> <1339133914-11148-4-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

> +     struct xfs_buf_map      map = {
> +             .bm_bn = blkno,
> +             .bm_len = numblks,
> +     };

I'm not a big fan of creative macro use, but with the amount of copies
of these line why not add a:

#define DEFINE_SINGLE_BUF_MAP(map, blkno, numblk) \
struct xfs_buf_map (map) = { .bm_bn = (blkno), .bm_len = (numblk) };

Otherwise looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/9] xfs: discontiguous directory buffer support, Dave Chinner [PATCH 3/9] xfs: add discontiguous buffer map interface, Dave Chinner Re: [PATCH 3/9] xfs: add discontiguous buffer map interface, Christoph Hellwig <= [PATCH 1/9] xfs: separate buffer indexing from block map, Dave Chinner Re: [PATCH 1/9] xfs: separate buffer indexing from block map, Ben Myers Re: [PATCH 1/9] xfs: separate buffer indexing from block map, Christoph Hellwig Re: [PATCH 1/9] xfs: separate buffer indexing from block map, Dave Chinner [PATCH 2/9] xfs: convert internal buffer functions to pass maps, Dave Chinner Re: [PATCH 2/9] xfs: convert internal buffer functions to pass maps, Ben Myers Re: [PATCH 2/9] xfs: convert internal buffer functions to pass maps, Ben Myers Re: [PATCH 2/9] xfs: convert internal buffer functions to pass maps, Christoph Hellwig Re: [PATCH 2/9] xfs: convert internal buffer functions to pass maps, Ben Myers Re: [PATCH 2/9] xfs: convert internal buffer functions to pass maps, Christoph Hellwig

Previous by Date:	Re: [PATCH 2/9] xfs: convert internal buffer functions to pass maps, Christoph Hellwig
Next by Date:	Re: [PATCH 4/9] xfs: add discontiguous buffer support to transactions, Christoph Hellwig
Previous by Thread:	[PATCH 3/9] xfs: add discontiguous buffer map interface, Dave Chinner
Next by Thread:	[PATCH 1/9] xfs: separate buffer indexing from block map, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]