Re: [PATCH] Prefix IO_XX flags with XFS_IO_XX to avoid namespace colisio

xfs

Re: [PATCH] Prefix IO_XX flags with XFS_IO_XX to avoid namespace colisio

To:	Alain Renaud <arenaud@xxxxxxx>
Subject:	Re: [PATCH] Prefix IO_XX flags with XFS_IO_XX to avoid namespace colision.
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Wed, 23 May 2012 09:24:24 +1000
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<4fbbfd75.nYwhMRRjLSAq0x8u%arenaud@xxxxxxx>
References:	<4fbbfd75.nYwhMRRjLSAq0x8u%arenaud@xxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Tue, May 22, 2012 at 03:56:21PM -0500, Alain Renaud wrote:
> 
>  This mod simply add a XFS_ prefix to IO_DIRECT,XFS_IO_DELALLOC,
> XFS_IO_UNWRITTEN and XFS_IO_OVERWRITE. This to avoid namespace conflict
> with other modules.

While I don't see any problems with making the change, I don't see
exactly how we could have a namespace clash here given they are
internal to XFS, not very widely included and have beenthis way for
years. What is the namespace clash you are seeing/caring about?

Cheers,

Dave.

-- 
Dave Chinner
david@xxxxxxxxxxxxx

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] Prefix IO_XX flags with XFS_IO_XX to avoid namespace colision., Alain Renaud Re: [PATCH] Prefix IO_XX flags with XFS_IO_XX to avoid namespace colision., Dave Chinner <= Re: [PATCH] Prefix IO_XX flags with XFS_IO_XX to avoid namespace colision., Alain Renaud

Previous by Date:	Re: [RFC PATCH 3/3] xfs: fix xfsaild hang due to lost wake ups, Dave Chinner
Next by Date:	Re: [PATCH] Prefix IO_XX flags with XFS_IO_XX to avoid namespace colision., Alain Renaud
Previous by Thread:	[PATCH] Prefix IO_XX flags with XFS_IO_XX to avoid namespace colision., Alain Renaud
Next by Thread:	Re: [PATCH] Prefix IO_XX flags with XFS_IO_XX to avoid namespace colision., Alain Renaud
Indexes:	[Date] [Thread] [Top] [All Lists]