| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 34/37] xfs: clean up xfs_bit.h includes |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Mon, 30 Apr 2012 12:40:47 +1000 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20120429215525.GM19889@xxxxxxxxxxxxx> |
| References: | <1335160747-17254-1-git-send-email-david@xxxxxxxxxxxxx> <1335160747-17254-35-git-send-email-david@xxxxxxxxxxxxx> <20120429215525.GM19889@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Sun, Apr 29, 2012 at 05:55:25PM -0400, Christoph Hellwig wrote:
> > * Visible inode allocation functions.
> > */
> > +/*
> > + * Find a free (set) bit in the inode bitmask.
> > + */
> > +static inline int xfs_ialloc_find_free(xfs_inofree_t *fp)
> > +{
> > + return xfs_lowbit64(*fp);
> > +}
>
> I'd suggest killing this helper entirely - there is just a single
> caller, and using the lowbit helper directly actually is even more
> obvious.
Ok. Done.
Cheers,
Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
|
| Previous by Date: | Re: [PATCH 37/37] xfs: make XBF_MAPPED the default behaviour, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 6/3] xfs: make largest supported offset less shouty, Dave Chinner |
| Previous by Thread: | Re: [PATCH 34/37] xfs: clean up xfs_bit.h includes, Christoph Hellwig |
| Next by Thread: | [PATCH 35/37] xfs: Properly exclude IO type flags from buffer flags, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |