| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 34/37] xfs: clean up xfs_bit.h includes |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Sun, 29 Apr 2012 17:55:25 -0400 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1335160747-17254-35-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1335160747-17254-1-git-send-email-david@xxxxxxxxxxxxx> <1335160747-17254-35-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
> * Visible inode allocation functions.
> */
> +/*
> + * Find a free (set) bit in the inode bitmask.
> + */
> +static inline int xfs_ialloc_find_free(xfs_inofree_t *fp)
> +{
> + return xfs_lowbit64(*fp);
> +}
I'd suggest killing this helper entirely - there is just a single
caller, and using the lowbit helper directly actually is even more
obvious.
|
| Previous by Date: | Re: [PATCH 33/37] xfs: move xfs_do_force_shutdown() and kill xfs_rw.c, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 35/37] xfs: Properly exclude IO type flags from buffer flags, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH 34/37] xfs: clean up xfs_bit.h includes, Mark Tinguely |
| Next by Thread: | Re: [PATCH 34/37] xfs: clean up xfs_bit.h includes, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |