| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 02/10] xfs: remove log item from AIL in xfs_iflush after a shutdown |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Fri, 13 Apr 2012 19:37:12 +1000 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20120327164644.420702935@xxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20120327164400.967415009@xxxxxxxxxxxxxxxxxxxxxx> <20120327164644.420702935@xxxxxxxxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Mar 27, 2012 at 12:44:02PM -0400, Christoph Hellwig wrote: > If a filesystem has been forced shutdown we are never going to write inodes > to disk, which means the inode items will stay in the AIL until we free > the inode. Currently that is not a problem, but a pending change requires us > to empty the AIL before shutting down the filesystem. In that case leaving > the inode in the AIL is lethal. Make sure to remove the log item from the AIL > to allow emptying the AIL on shutdown filesystems. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Simplifies things a lot - abort immediately rather than leave it for someone else to cleanup. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 01/10] xfs: remove log item from AIL in xfs_qm_dqflush after a shutdown, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 03/10] xfs: allow assigning the tail lsn with the AIL lock held, Dave Chinner |
| Previous by Thread: | Re: [PATCH 01/10] xfs: remove log item from AIL in xfs_qm_dqflush after a shutdown, Dave Chinner |
| Next by Thread: | Re: [PATCH 03/10] xfs: allow assigning the tail lsn with the AIL lock held, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |