| To: | Jeff Liu <jeff.liu@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs: don't fill statvfs with project quota for a directory if it was not enabled. |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Wed, 11 Apr 2012 15:59:15 -0400 |
| Cc: | xfs@xxxxxxxxxxx, Ben Myers <bpm@xxxxxxx> |
| In-reply-to: | <4F77DFDB.1040802@xxxxxxxxxx> |
| References: | <4F77DFDB.1040802@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
Sorry for taking so long to get back to this, but conferences and work kept me really busy the last two weeks. > - if ((ip->i_d.di_flags & XFS_DIFLAG_PROJINHERIT) || > - ((mp->m_qflags & (XFS_PQUOTA_ACCT|XFS_OQUOTA_ENFD))) == > - (XFS_PQUOTA_ACCT|XFS_OQUOTA_ENFD)) > - xfs_qm_statvfs(ip, statp); I thjink the correct fix here is to replace the || between the inode flag and quota flag check with and && - we want both the above conditions to be true. Can you respin the patch by doing that and make sure it still passes the test case? I'd like to send it of to -stable ASAP. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] disable tags in post-receive hook, Ben Myers |
|---|---|
| Next by Date: | Re: [PATCH] xfstests: Introduce test case 285 for project quota negative test collections, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH] xfs: don't fill statvfs with project quota for a directory if it was not enabled., Jeff Liu |
| Next by Thread: | Re: [PATCH] xfs: don't fill statvfs with project quota for a directory if it was not enabled., sn0wing |
| Indexes: | [Date] [Thread] [Top] [All Lists] |