| To: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/1] xfs: use XFS_BMAP_BMDR_SPACE vs. XFS_BROOT_SIZE_ADJ |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Thu, 29 Mar 2012 11:55:40 +1100 |
| Cc: | Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx> |
| In-reply-to: | <4F734887.7000508@xxxxxxxxxxx> |
| References: | <4F7225BA.40200@xxxxxxxxxx> <4F734887.7000508@xxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Wed, Mar 28, 2012 at 12:21:11PM -0500, Eric Sandeen wrote: > XFS_BROOT_SIZE_ADJ is an undocumented macro which accounts for > the difference in size between the on-disk and in-core btree > root. It's much clearer to just use the newly-added > XFS_BMAP_BMDR_SPACE macro which gives us the on-disk size > directly. > > In one case, we must test that the if_broot exists before > applying the macro, however. > > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> Looks good. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 00/10] remove xfsbufd, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH] mkfs.xfs: print std info if agcount makes agsize out of bounds, Dave Chinner |
| Previous by Thread: | [PATCH 2/1] xfs: use XFS_BMAP_BMDR_SPACE vs. XFS_BROOT_SIZE_ADJ, Eric Sandeen |
| Next by Thread: | [XFS updates] XFS development tree branch, master, updated. v3.2-rc1-11488-g5a5881c, xfs |
| Indexes: | [Date] [Thread] [Top] [All Lists] |