| To: | Eric Sandeen <sandeen@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfstests 235: do smaller test IO |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Tue, 27 Mar 2012 12:18:34 +1100 |
| Cc: | xfs-oss <xfs@xxxxxxxxxxx>, Eryu Guan <eguan@xxxxxxxxxx> |
| In-reply-to: | <4F70EBD8.9030006@xxxxxxxxxx> |
| References: | <4F70C3D9.80708@xxxxxxxxxx> <20120326220926.GO5091@dastard> <4F70EBD8.9030006@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Mon, Mar 26, 2012 at 05:21:12PM -0500, Eric Sandeen wrote: > On 3/26/12 5:09 PM, Dave Chinner wrote: > > On Mon, Mar 26, 2012 at 02:30:33PM -0500, Eric Sandeen wrote: > >> Test 235 fails on ext2/ext3 with 1024 fs block size because a > >> 16k write uses an extra metadata block. If we do a smaller write > >> this won't happen. > > ..... > >> > >> -$XFS_IO_PROG -F -c 'pwrite 0 16k' -c 'fsync' \ > >> +$XFS_IO_PROG -F -c 'pwrite 0 8k' -c 'fsync' \ > > > > So now it fails only on 512 byte block size filesystems? > > ext[23] don't do 512 byte block filesystems, so no. ;) Oh, I forgot about that. Well, just ignore me. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 4/5] xfs: push the ilock into xfs_zero_eof, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 5/5] xfs: use shared ilock mode for direct IO writes by default, Dave Chinner |
| Previous by Thread: | Re: [PATCH] xfstests 235: do smaller test IO, Eric Sandeen |
| Next by Thread: | [PATCH 0/5] reduce exclusive ilock hold times, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |