xfs
[Top] [All Lists]

Re: [PATCH 2/2] xfs: avoid shutdown hang in xlog_wait()

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/2] xfs: avoid shutdown hang in xlog_wait()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 25 Mar 2012 07:28:01 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20120324224648.GF5091@dastard>
References: <1332467263-12985-1-git-send-email-david@xxxxxxxxxxxxx> <1332467263-12985-3-git-send-email-david@xxxxxxxxxxxxx> <20120324170302.GB21708@xxxxxxxxxxxxx> <20120324224648.GF5091@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sun, Mar 25, 2012 at 09:46:49AM +1100, Dave Chinner wrote:
> > Looks good.  I wonder if it might be simple to simply pass a flags
> > argument to xfs_ail_delete(_bulk) which tells which kind of shutdown
> > to do.
> 
> I thought about doing that, but it seems strange and unusual to tell
> code how to handle errors internally instead of returning the error
> and letting the caller handle it...
> 
> I don't mind either way, though. If you prefer I pass in the
> shutdown flag, I can change it all to do that....

I don't have a strong opinion.  Moving the shutdown to the caller is
cleaner for sure, but it's a lot of churn when the other version would

<Prev in Thread] Current Thread [Next in Thread>