Re: [PATCH 4/8] xfs: log file size updates at I/O completion time

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 4/8] xfs: log file size updates at I/O completion time
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Tue, 28 Feb 2012 06:07:13 -0500
Cc:	Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to:	<20120221050526.GK3592@dastard>
References:	<20120221003824.415885674@xxxxxxxxxxxxxxxxxxxxxx> <20120221003906.670163670@xxxxxxxxxxxxxxxxxxxxxx> <20120221050526.GK3592@dastard>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Tue, Feb 21, 2012 at 04:05:26PM +1100, Dave Chinner wrote:
> Hmmm, I missed something here first time through: do we need to
> restore the PF_FSTRANS flag here before cancelling the transaction?
> I don't think we do (clearing a flag that is aready cleared is not a
> problem), but we should be consistent with the IO completion
> handling of this transaction.

I don't think we'll need it either, but I'll fix it up anyway.

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/8] log all inode updates V2, Christoph Hellwig [PATCH 3/8] xfs: log file size updates as part of unwritten extent conversion, Christoph Hellwig [PATCH 4/8] xfs: log file size updates at I/O completion time, Christoph Hellwig Re: [PATCH 4/8] xfs: log file size updates at I/O completion time, Dave Chinner Re: [PATCH 4/8] xfs: log file size updates at I/O completion time, Christoph Hellwig <= [PATCH 8/8] xfs: add back fdatasync support, Christoph Hellwig Re: [PATCH 8/8] xfs: add back fdatasync support, Dave Chinner [PATCH 6/8] xfs: make xfs_inode_item_size idempotent, Christoph Hellwig Re: [PATCH 6/8] xfs: make xfs_inode_item_size idempotent, Dave Chinner Re: [PATCH 6/8] xfs: make xfs_inode_item_size idempotent, Christoph Hellwig [PATCH 2/8] xfs: do not require an ioend for new EOF calculation, Christoph Hellwig Re: [PATCH 2/8] xfs: do not require an ioend for new EOF calculation, Mark Tinguely [PATCH 1/8] xfs: use per-filesystem I/O completion workqueues, Christoph Hellwig Re: [PATCH 1/8] xfs: use per-filesystem I/O completion workqueues, Dave Chinner Re: [PATCH 1/8] xfs: use per-filesystem I/O completion workqueues, Mark Tinguely

Previous by Date:	[PATCH] xfs: trace xfs_name strings correctly, Christoph Hellwig
Next by Date:	Re: [PATCH 6/8] xfs: make xfs_inode_item_size idempotent, Christoph Hellwig
Previous by Thread:	Re: [PATCH 4/8] xfs: log file size updates at I/O completion time, Dave Chinner
Next by Thread:	[PATCH 8/8] xfs: add back fdatasync support, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]