Re: [PATCH 5/8] xfs: log timestamp updates

[Dave Chinner <david@xxxxxxxxxxxxx>]

On Mon, Feb 20, 2012 at 07:38:29PM -0500, Christoph Hellwig wrote:
> Timestamps on regular files are the last metadata that XFS does not update
> transactionally.  Now that we use the delaylog mode exclusively and made
> the log scode scale extremly well there is no need to bypass that code for
> timestamp updates.  Logging all updates allows to drop a lot of code, and
> will allow for further performance improvements later on.
> 
> Note that this patch drops optimized handling of fdatasync - it will be
> added back in a separate commit.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good. Be nice if we coulxp dreturn an error from .dirty_inode,
but we can't really do anything with it, anyway.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx