Re: [PATCH] xfsprogs: skip FSGEOMETRY call in openfile if no geom var pr

xfs

Re: [PATCH] xfsprogs: skip FSGEOMETRY call in openfile if no geom var pr

To:	Eric Sandeen <sandeen@xxxxxxxxxx>
Subject:	Re: [PATCH] xfsprogs: skip FSGEOMETRY call in openfile if no geom var present
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Fri, 17 Feb 2012 12:21:32 -0500
Cc:	xfs-oss <xfs@xxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>
In-reply-to:	<4F3AAA03.2010305@xxxxxxxxxx>
References:	<4F3AAA03.2010305@xxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Tue, Feb 14, 2012 at 10:37:55AM -0800, Eric Sandeen wrote:
> sendfile_f() calls openfile() with NULL *geom even if it's on an
> xfs filesystem, so we need to skip the ioctl if (!geom).
> 
> Fixes regression from d1b88183bb3fc5e338746db53269310348646753
> 
> Reported-by: Christoph Hellwig <hch@xxxxxxxxxxxxx>
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] xfsprogs: skip FSGEOMETRY call in openfile if no geom var present, Eric Sandeen Re: [PATCH] xfsprogs: skip FSGEOMETRY call in openfile if no geom var present, Christoph Hellwig <=

Previous by Date:	Re: [PATCH] xfstests: more careful size grep in 256, Christoph Hellwig
Next by Date:	Re: [PATCH] repair: fix a few message formats in process_dinode_int, Christoph Hellwig
Previous by Thread:	[PATCH] xfsprogs: skip FSGEOMETRY call in openfile if no geom var present, Eric Sandeen
Next by Thread:	xfs_fsr (defragmenting) 'XFS_IOC_SWAPEXT failed: ino=xxxxxx: Invalid argument' error, Tom Crane
Indexes:	[Date] [Thread] [Top] [All Lists]