On Mon, Jan 23, 2012 at 08:31:00AM -0600, Mark Tinguely wrote:
> On 01/-10/63 13:59, Christoph Hellwig wrote:
>> There is no reason to wake up log space waiters when unlocking inodes or
>> dquots, and the commit log has no explanation for this function either.
>>
>> Given that we now have exact log space wakeups everywhere we can assume
>> to reason for this function was to paper over log space races in earlier
the
>> XFS versions.
>>
>> Signed-off-by: Christoph Hellwig<hch@xxxxxx>
>
> I agree, these unlock won't change the amount of available log space.
>
> I did not find the exact reason for these original calls the the log
> space wake routines.
>
> Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>
I agree too. Christoph's assessment that "the reason for this function was
to paper over log space races" seems spot on, and it's nice to get rid
of xfs_trans_unlocked_item.
Reviewed-by: Ben Myers <bpm@xxxxxxx>
|