| To: | Mitsuo Hayasaka <mitsuo.hayasaka.hu@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH -v2 2/3] xfs: make inode quota check more general |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Tue, 14 Feb 2012 21:32:49 -0500 |
| Cc: | Ben Myers <bpm@xxxxxxx>, Alex Elder <aelder@xxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Alex Elder <elder@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, xfs-masters@xxxxxxxxxxx, yrl.pp-manager.tt@xxxxxxxxxxx |
| In-reply-to: | <20120206125030.12624.95365.stgit@xxxxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20120206124951.12624.88233.stgit@xxxxxxxxxxxxxxxxxxxxxxxx> <20120206125030.12624.95365.stgit@xxxxxxxxxxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Mon, Feb 06, 2012 at 09:50:30PM +0900, Mitsuo Hayasaka wrote: > The xfs checks quota when reserving disk blocks and inodes. In the block > reservation, it checks if the total number of blocks including current > usage and new reservation exceed quota. In the inode reservation, > it checks using the total number of inodes including only current usage > without new reservation. However, this inode quota check works well > since the caller of xfs_trans_dquot() always sets the argument of the > number of new inode reservation to 1 or 0 and inode is reserved one by > one in current xfs. > > To make it more general, this patch changes it to the same way as the > block quota check. Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH -v2 1/3] xfs: change available ranges of softlimit and hardlimit in quota check, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH -v2 3/3] xfs: cleanup quota check on disk blocks and inodes reservations, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH -v2 2/3] xfs: make inode quota check more general, Mark Tinguely |
| Next by Thread: | [PATCH -v2 3/3] xfs: cleanup quota check on disk blocks and inodes reservations, Mitsuo Hayasaka |
| Indexes: | [Date] [Thread] [Top] [All Lists] |