xfs
[Top] [All Lists]

Re: [PATCH] XFS; xfs_trans_add_item() - don't assign in ASSERT() when co

To: Jesper Juhl <jj@xxxxxxxxxxxxx>
Subject: Re: [PATCH] XFS; xfs_trans_add_item() - don't assign in ASSERT() when compare is intended
From: Ben Myers <bpm@xxxxxxx>
Date: Mon, 13 Feb 2012 15:10:27 -0600
Cc: xfs@xxxxxxxxxxx, xfs-masters@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Alex Elder <elder@xxxxxxxxxx>
In-reply-to: <alpine.LNX.2.00.1202132149270.16039@xxxxxxxxxxxxxxxxxxxxxxxxx>
References: <alpine.LNX.2.00.1202132149270.16039@xxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Mon, Feb 13, 2012 at 09:51:05PM +0100, Jesper Juhl wrote:
> It looks to me like the two ASSERT()s in xfs_trans_add_item() really
> want to do a compare (==) rather than assignment (=).
> This patch changes it from the former to the latter.
                                 latter        former

I'll update your comment as you suggested.

> I must admit though, that I don't know this code well and have only
> compile tested this change. But if assignment is really intended it
> really seems strange to do it as part of an ASSERT...
> 
> Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx>
> ---
>  fs/xfs/xfs_trans.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/xfs/xfs_trans.c b/fs/xfs/xfs_trans.c
> index 329b06a..7adcdf1 100644
> --- a/fs/xfs/xfs_trans.c
> +++ b/fs/xfs/xfs_trans.c
> @@ -1151,8 +1151,8 @@ xfs_trans_add_item(
>  {
>       struct xfs_log_item_desc *lidp;
>  
> -     ASSERT(lip->li_mountp = tp->t_mountp);
> -     ASSERT(lip->li_ailp = tp->t_mountp->m_ail);
> +     ASSERT(lip->li_mountp == tp->t_mountp);
> +     ASSERT(lip->li_ailp == tp->t_mountp->m_ail);

Yeah, nice find...  ;)
Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>