| To: | Liu Bo <liubo2009@xxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 3/3] xfstests: add btrfs online defragments QA test |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Mon, 6 Feb 2012 07:11:55 -0500 |
| Cc: | linux-btrfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, hch@xxxxxxxxxxxxx |
| In-reply-to: | <1328516869-19474-3-git-send-email-liubo2009@xxxxxxxxxxxxxx> |
| References: | <1328516869-19474-1-git-send-email-liubo2009@xxxxxxxxxxxxxx> <1328516869-19474-3-git-send-email-liubo2009@xxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Mon, Feb 06, 2012 at 04:27:49PM +0800, Liu Bo wrote:
> +_runtest()
> +{
> + $progs_dir/runtest.sh $defrag_args $SCRATCH_MNT $SCRATCH_DEV
please put the actual tests into test cases themselves instead of
calling out into shell scripts under src. If you have common code
shared between multiple tests please put them into common.defrag.
> +
> +# get standard environment, filters and checks
> +. ./common.rc
> +. ./common.filter
> +. ./common.defrag
> +
> +# real QA test starts here
> +_supported_fs xfs btrfs
does it really support xfs?
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: xfs_repair segfaults with ag_stride option, Tom Crane |
|---|---|
| Next by Date: | [PATCH -v2 0/3] xfs: change available ranges in quota check, Mitsuo Hayasaka |
| Previous by Thread: | [PATCH 3/3] xfstests: add btrfs online defragments QA test, Liu Bo |
| Next by Thread: | Re: [PATCH 3/3] xfstests: add btrfs online defragments QA test, Liu Bo |
| Indexes: | [Date] [Thread] [Top] [All Lists] |