| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs_quota: remove calls to XFS_QSYNC |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Wed, 1 Feb 2012 05:24:36 -0500 |
| Cc: | Ben Myers <bpm@xxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Nathan Scott <nathans@xxxxxxxxxx>, xfs@xxxxxxxxxxx |
| In-reply-to: | <20120131210110.GN9090@dastard> |
| References: | <20120130115024.GA884@xxxxxxxxxxxxx> <CAAp5ZgNKsY-OrWyDNU70KUKYCZUX_EvzngAvBsBTgrgkK6KyMA@xxxxxxxxxxxxxx> <20120131162617.GF7762@xxxxxxx> <20120131210110.GN9090@dastard> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Wed, Feb 01, 2012 at 08:01:10AM +1100, Dave Chinner wrote: > So effectively what that says to me is that quota only exports the > real block usage, even though it internally tracks delalloc > reservations. Perhaps an additionaly change to make in this case is > to fold the reserved blocks into what is reported to the quota > utilities? > > Indeed, what is exported to userspace via xfs_qm_export_dquot() is > the information in the dquot core - the on-disk information - so > perhaps all we need to do is export dqp->q_res_bcount (the count of > real + reserved blocks) instead of the on-disk info? That seems like a good idea, given that enforcement takes the reservation into account. To retain compatbility for the case of new userspace and an old kernel I'd have to disable Q_XQUOTASYNC in the kernel intead of in the tool, though. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Performance problem - reads slower than writes, Stan Hoeppner |
|---|---|
| Next by Date: | Re: [patch] xfs: remove an unneeded NULL check, Christoph Hellwig |
| Previous by Thread: | Re: Performance problem - reads slower than writes, Stan Hoeppner |
| Next by Thread: | Re: [patch] xfs: remove an unneeded NULL check, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |