| To: | Ben Myers <bpm@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/2] xfs: fix endian conversion issue in discard code |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Fri, 6 Jan 2012 10:12:54 -0500 |
| Cc: | Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx |
| In-reply-to: | <20111221043638.GR29840@xxxxxxx> |
| References: | <1324426062-21505-1-git-send-email-david@xxxxxxxxxxxxx> <1324426062-21505-3-git-send-email-david@xxxxxxxxxxxxx> <20111221043638.GR29840@xxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Dec 20, 2011 at 10:36:38PM -0600, Ben Myers wrote: > On Wed, Dec 21, 2011 at 11:07:42AM +1100, Dave Chinner wrote: > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > > > When finding the longest extent in an AG, we read the value directly > > out of the AGF buffer without endian conversion. This will give an > > incorrect length, resulting in FITRIM operations potentially not > > trimming everything that it should. > > Looks good to me. > > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> > > Reviewed-by: Ben Myers <bpm@xxxxxxx> This is a pretty serious thing, can you send it to Linus as soon as he takes the current pull request? |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Introduce SEEK_DATA/SEEK_HOLE to XFS V5, Jeff Liu |
|---|---|
| Next by Date: | Re: [PATCH 2/2] xfs: fix endian conversion issue in discard code, Ben Myers |
| Previous by Thread: | Introduce SEEK_DATA/SEEK_HOLE to XFS V5, Jeff Liu |
| Next by Thread: | Re: [PATCH 2/2] xfs: fix endian conversion issue in discard code, Ben Myers |
| Indexes: | [Date] [Thread] [Top] [All Lists] |