Re: [PATCH 12/12] xfs: remove duplication in transaction buffer operatio

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 12/12] xfs: remove duplication in transaction buffer operations
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Sat, 17 Dec 2011 18:32:38 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1323238703-13198-13-git-send-email-david@xxxxxxxxxxxxx>
References:	<1323238703-13198-1-git-send-email-david@xxxxxxxxxxxxx> <1323238703-13198-13-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

> @@ -213,8 +147,6 @@ xfs_trans_get_buf_irec(
>       struct xfs_buf          *bp;
>       struct xfs_buf_log_item *bip;
>  
> -     ASSERT_ALWAYS(nmaps == 1);
> -

Shouldn't this have been removed as soon as actual multiple buffer
support was introduced?

> @@ -528,8 +303,6 @@ xfs_trans_read_buf_irec(
>       xfs_buf_log_item_t      *bip;
>       int                     error;
>  
> -     ASSERT_ALWAYS(nmaps == 1);
> -

Same here.

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 04/12] xfs: add compound buffer get and read interfaces, (continued) Re: [PATCH 04/12] xfs: add compound buffer get and read interfaces, Christoph Hellwig [PATCH 06/12] xfs: convert xfs_da_do_buf to use irec buffer interface, Dave Chinner [PATCH 03/12] xfs: introduce a compound buffer construct, Dave Chinner Re: [PATCH 03/12] xfs: introduce a compound buffer construct, Christoph Hellwig [PATCH 08/12] xfs: support multiple irec maps in buffer code, Dave Chinner [PATCH 10/12] xfs: use multiple irec xfs buf support in dabuf, Dave Chinner [PATCH 09/12] xfs: support compund buffers in buf_item logging, Dave Chinner [PATCH 07/12] xfs: switch the buffer get/read API to use irec methods, Dave Chinner [PATCH 05/12] xfs: add irec interfaces to xfs_trans_buf_get/read, Dave Chinner [PATCH 12/12] xfs: remove duplication in transaction buffer operations, Dave Chinner Re: [PATCH 12/12] xfs: remove duplication in transaction buffer operations, Christoph Hellwig <= [PATCH 11/12] xfs: remove struct xfs_dabuf and infrastructure, Dave Chinner Re: [PATCH 11/12] xfs: remove struct xfs_dabuf and infrastructure, Christoph Hellwig Re: [RFC, PATCH 0/12] xfs: compound buffers for directory blocks, Christoph Hellwig Re: [RFC, PATCH 0/12] xfs: compound buffers for directory blocks, Dave Chinner Re: [RFC, PATCH 0/12] xfs: compound buffers for directory blocks, Christoph Hellwig Re: [RFC, PATCH 0/12] xfs: compound buffers for directory blocks, Dave Chinner

Previous by Date:	Re: [PATCH 11/12] xfs: remove struct xfs_dabuf and infrastructure, Christoph Hellwig
Next by Date:	[PATCH 1/1] xfs: log the inode in ->write_inode calls for kupdate, Christoph Hellwig
Previous by Thread:	[PATCH 12/12] xfs: remove duplication in transaction buffer operations, Dave Chinner
Next by Thread:	[PATCH 11/12] xfs: remove struct xfs_dabuf and infrastructure, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]