Re: [PATCH 04/12] xfs: add compound buffer get and read interfaces

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 04/12] xfs: add compound buffer get and read interfaces
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Sat, 17 Dec 2011 18:14:19 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1323238703-13198-5-git-send-email-david@xxxxxxxxxxxxx>
References:	<1323238703-13198-1-git-send-email-david@xxxxxxxxxxxxx> <1323238703-13198-5-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

After looking over all the patches I really thing we should be passing
struct xfs_buf_vec arguments to the functions, and provide a helper
to convert struct xfs_bmbt_irec to the callers.  That avoids having to
add the XFS_EXT_DADDR hack, and keeps the amount of data structures
used in the buffer cache small.

<Prev in Thread]	Current Thread	[Next in Thread>
[RFC, PATCH 0/12] xfs: compound buffers for directory blocks, Dave Chinner [PATCH 01/12] xfs: remove remaining scraps of struct xfs_iomap, Dave Chinner Re: [PATCH 01/12] xfs: remove remaining scraps of struct xfs_iomap, Christoph Hellwig [PATCH 02/12] xfs: clean up buffer get/read call API, Dave Chinner Re: [PATCH 02/12] xfs: clean up buffer get/read call API, Christoph Hellwig [PATCH 04/12] xfs: add compound buffer get and read interfaces, Dave Chinner Re: [PATCH 04/12] xfs: add compound buffer get and read interfaces, Christoph Hellwig <= [PATCH 06/12] xfs: convert xfs_da_do_buf to use irec buffer interface, Dave Chinner [PATCH 03/12] xfs: introduce a compound buffer construct, Dave Chinner Re: [PATCH 03/12] xfs: introduce a compound buffer construct, Christoph Hellwig [PATCH 08/12] xfs: support multiple irec maps in buffer code, Dave Chinner [PATCH 10/12] xfs: use multiple irec xfs buf support in dabuf, Dave Chinner [PATCH 09/12] xfs: support compund buffers in buf_item logging, Dave Chinner [PATCH 07/12] xfs: switch the buffer get/read API to use irec methods, Dave Chinner [PATCH 05/12] xfs: add irec interfaces to xfs_trans_buf_get/read, Dave Chinner [PATCH 12/12] xfs: remove duplication in transaction buffer operations, Dave Chinner Re: [PATCH 12/12] xfs: remove duplication in transaction buffer operations, Christoph Hellwig

Previous by Date:	Re: [PATCH 03/12] xfs: introduce a compound buffer construct, Christoph Hellwig
Next by Date:	Re: [PATCH 11/12] xfs: remove struct xfs_dabuf and infrastructure, Christoph Hellwig
Previous by Thread:	[PATCH 04/12] xfs: add compound buffer get and read interfaces, Dave Chinner
Next by Thread:	[PATCH 06/12] xfs: convert xfs_da_do_buf to use irec buffer interface, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]