Re: [PATCH 10/11] xfs: always return with the iolock held from xfs_file

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 10/11] xfs: always return with the iolock held from xfs_file_aio_write_checks
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Wed, 14 Dec 2011 08:27:10 -0500
Cc:	Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to:	<20111213232017.GH3179@dastard>
References:	<20111208155755.323930705@xxxxxxxxxxxxxxxxxxxxxx> <20111208155919.215723395@xxxxxxxxxxxxxxxxxxxxxx> <20111213232017.GH3179@dastard>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Wed, Dec 14, 2011 at 10:20:17AM +1100, Dave Chinner wrote:
> On Thu, Dec 08, 2011 at 10:58:05AM -0500, Christoph Hellwig wrote:
> > While xfs_iunlock is fine with 0 lockflags the calling conventions are much
> > cleaner if xfs_file_aio_write_checks never returns without the iolock held.
> > 
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> I'm not sure this makes sense by itself. maybe combine it with the
> next patch? Regardless:

I actually had it that way initially but split the patches because the
changes aren't directly related.

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 00/11] inode shrink and misc updates, Christoph Hellwig [PATCH 03/11] xfs: remove the unused dm_attrs structure, Christoph Hellwig [PATCH 02/11] xfs: cleanup xfs_iomap_eof_align_last_fsb, Christoph Hellwig Re: [PATCH 02/11] xfs: cleanup xfs_iomap_eof_align_last_fsb, Dave Chinner [PATCH 07/11] xfs: replace i_pin_wait with a bit waitqueue, Christoph Hellwig Re: [PATCH 07/11] xfs: replace i_pin_wait with a bit waitqueue, Dave Chinner [PATCH 05/11] xfs: make i_flags an unsigned long, Christoph Hellwig [PATCH 10/11] xfs: always return with the iolock held from xfs_file_aio_write_checks, Christoph Hellwig Re: [PATCH 10/11] xfs: always return with the iolock held from xfs_file_aio_write_checks, Dave Chinner Re: [PATCH 10/11] xfs: always return with the iolock held from xfs_file_aio_write_checks, Christoph Hellwig <= [PATCH 01/11] xfs: remove xfs_itruncate_data, Christoph Hellwig Re: [PATCH 01/11] xfs: remove xfs_itruncate_data, Dave Chinner [PATCH 09/11] xfs: remove the i_new_size field in struct xfs_inode, Christoph Hellwig Re: [PATCH 09/11] xfs: remove the i_new_size field in struct xfs_inode, Dave Chinner Re: [PATCH 09/11] xfs: remove the i_new_size field in struct xfs_inode, Christoph Hellwig [PATCH 04/11] xfs: remove the if_ext_max field in struct xfs_ifork, Christoph Hellwig Re: [PATCH 04/11] xfs: remove the if_ext_max field in struct xfs_ifork, Dave Chinner [PATCH 11/11] xfs: cleanup xfs_file_aio_write, Christoph Hellwig Re: [PATCH 11/11] xfs: cleanup xfs_file_aio_write, Dave Chinner [PATCH 06/11] xfs: replace i_flock with a sleeping bitlock, Christoph Hellwig

Previous by Date:	Re: [PATCH 09/11] xfs: remove the i_new_size field in struct xfs_inode, Christoph Hellwig
Next by Date:	Re: xfs-trace-ilock-more, Mark Fasheh
Previous by Thread:	Re: [PATCH 10/11] xfs: always return with the iolock held from xfs_file_aio_write_checks, Dave Chinner
Next by Thread:	[PATCH 01/11] xfs: remove xfs_itruncate_data, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [PATCH 10/11] xfs: always return with the iolock held from xfs_file_