| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 10/11] xfs: always return with the iolock held from xfs_file_aio_write_checks |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Wed, 14 Dec 2011 10:20:17 +1100 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20111208155919.215723395@xxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20111208155755.323930705@xxxxxxxxxxxxxxxxxxxxxx> <20111208155919.215723395@xxxxxxxxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Thu, Dec 08, 2011 at 10:58:05AM -0500, Christoph Hellwig wrote: > While xfs_iunlock is fine with 0 lockflags the calling conventions are much > cleaner if xfs_file_aio_write_checks never returns without the iolock held. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> I'm not sure this makes sense by itself. maybe combine it with the next patch? Regardless: Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| Previous by Date: | Re: [PATCH 09/11] xfs: remove the i_new_size field in struct xfs_inode, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH] xfs: remove unused XBT_FORCE_SLEEP bit, Dave Chinner |
| Previous by Thread: | [PATCH 10/11] xfs: always return with the iolock held from xfs_file_aio_write_checks, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 10/11] xfs: always return with the iolock held from xfs_file_aio_write_checks, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |