Re: [patch 12/19] xfs: flatten the dquot lock ordering

xfs

Re: [patch 12/19] xfs: flatten the dquot lock ordering

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [patch 12/19] xfs: flatten the dquot lock ordering
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Wed, 14 Dec 2011 06:44:57 +1100
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20111206215854.769664827@xxxxxxxxxxxxxxxxxxxxxx>
References:	<20111206215806.844405397@xxxxxxxxxxxxxxxxxxxxxx> <20111206215854.769664827@xxxxxxxxxxxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Tue, Dec 06, 2011 at 04:58:18PM -0500, Christoph Hellwig wrote:
> Introduce a new XFS_DQ_FREEING flag that tells lookup and mplist walks
> to skip a dquot that is beeing freed, and use this avoid the trylock
> on the hash and mplist locks in xfs_qm_dqreclaim_one.  Also simplify
> xfs_dqpurge by moving the inodes to a dispose list after marking them
> XFS_DQ_FREEING and avoid the locker ordering constraints.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good to me withthe coment updates.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [patch 08/19] xfs: cleanup dquot locking helpers, (continued) Re: [patch 08/19] xfs: cleanup dquot locking helpers, Ben Myers [patch 17/19] xfs: merge xfs_qm_dqinit_core into the only caller, Christoph Hellwig Re: [patch 17/19] xfs: merge xfs_qm_dqinit_core into the only caller, Ben Myers [patch 13/19] xfs: nest qm_dqfrlist_lock inside the dquot qlock, Christoph Hellwig Re: [patch 13/19] xfs: nest qm_dqfrlist_lock inside the dquot qlock, Ben Myers [patch 16/19] xfs: add a xfs_dqhold helper, Christoph Hellwig Re: [patch 16/19] xfs: add a xfs_dqhold helper, Ben Myers [patch 19/19] xfs: remove XFS_QMOPT_DQSUSER, Christoph Hellwig Re: [patch 19/19] xfs: remove XFS_QMOPT_DQSUSER, Ben Myers [patch 12/19] xfs: flatten the dquot lock ordering, Christoph Hellwig Re: [patch 12/19] xfs: flatten the dquot lock ordering, Dave Chinner <= Re: [patch 12/19] xfs: flatten the dquot lock ordering, Ben Myers Re: [patch 12/19] xfs: flatten the dquot lock ordering, Ben Myers [patch 18/19] xfs: kill xfs_qm_idtodq, Christoph Hellwig Re: [patch 18/19] xfs: kill xfs_qm_idtodq, Ben Myers

Previous by Date:	Usted Has Ganado La LoteriaPremio, Ofiiciale Premio
Next by Date:	Re: [patch 10/19] xfs: remove XFS_DQ_INACTIVE, Ben Myers
Previous by Thread:	[patch 12/19] xfs: flatten the dquot lock ordering, Christoph Hellwig
Next by Thread:	Re: [patch 12/19] xfs: flatten the dquot lock ordering, Ben Myers
Indexes:	[Date] [Thread] [Top] [All Lists]