| To: | Simon Kirby <sim@xxxxxxxxxx> |
|---|---|
| Subject: | Re: XFS read hangs in 3.1-rc10 |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Mon, 28 Nov 2011 14:55:05 -0500 |
| Cc: | linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, bpm@xxxxxxx |
| In-reply-to: | <20111128190554.GA31168@xxxxxxxxxx> |
| References: | <20111020224214.GC22772@xxxxxxxxxx> <20111021132240.GA24136@xxxxxxxxxxxxx> <20111021202857.GB30100@xxxxxxxxxx> <20111024082219.GA19941@xxxxxxxxxxxxx> <20111025200748.GA25043@xxxxxxxxxx> <20111026112521.GA10432@xxxxxxxxxxxxx> <20111104210324.GB14983@xxxxxxxxxxxxx> <20111116195643.GF24411@xxxxxxxxxx> <20111120153241.GA23511@xxxxxxxxxxxxx> <20111128190554.GA31168@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Mon, Nov 28, 2011 at 11:05:54AM -0800, Simon Kirby wrote: > On Sun, Nov 20, 2011 at 10:32:41AM -0500, Christoph Hellwig wrote: > > > On Wed, Nov 16, 2011 at 11:56:43AM -0800, Simon Kirby wrote: > > > Sorry for the delay in testing. > > > > > > Yes, everything looks fine even with the xfs_log_force line from your > > > patch commented out. So, the changes in xfs_reclaim_inode() are just the > > > set_bit(XBT_FORCE_FLUSH) and wake_up_process(), relative to 3.1. > > > > Dave pointed out that we can do better than the big hammer, and the > > patch below should fix your issue, too. Can you test it? > > Yes, seems to be fine. No hung task warnings, tested for ~5 days. Thanks a lot for the testing Simon. Ben, can you add a: Tested-by: Simon Kirby <sim@xxxxxxxxxx> to the patch when applying it? |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: XFS read hangs in 3.1-rc10, Simon Kirby |
|---|---|
| Next by Date: | Re: XFS read hangs in 3.1-rc10, Ben Myers |
| Previous by Thread: | Re: XFS read hangs in 3.1-rc10, Simon Kirby |
| Next by Thread: | Re: XFS read hangs in 3.1-rc10, Ben Myers |
| Indexes: | [Date] [Thread] [Top] [All Lists] |