xfs
[Top] [All Lists]

Re: [PATCH 1/9] xfstests: fsstress add command line style output for sho

To: Dmitry Monakhov <dmonakhov@xxxxxxxxxx>
Subject: Re: [PATCH 1/9] xfstests: fsstress add command line style output for show_opts
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 8 Nov 2011 07:52:50 +1100
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, hch@xxxxxx, aelder@xxxxxxx, tytso@xxxxxxx
In-reply-to: <1320342953-7973-1-git-send-email-dmonakhov@xxxxxxxxxx>
References: <1320342953-7973-1-git-send-email-dmonakhov@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Nov 03, 2011 at 09:55:45PM +0400, Dmitry Monakhov wrote:
> Once some combination of seed+fs_ops result in regression it is
> reasonable to document that combination. It is usefull to dump
> that configuration in command line style. Later this line may be
> simply hardcoded in to regression test.
.....

> @@ -345,7 +345,10 @@ int main(int argc, char **argv)
>                       zero_freq();
>                       break;
>               case 'S':
> -                     show_ops(0, NULL);
> +                     i = 0;
> +                     if (optarg[0] == 'c')
> +                             i = 1;
> +                     show_ops(1, NULL);

I don't think that does what it is supposed to do...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>