| To: | Alex Elder <aelder@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] Fix possible memory corruption in xfs_readlink |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Wed, 2 Nov 2011 15:45:07 -0400 |
| Cc: | Ben Hutchings <ben@xxxxxxxxxxxxxxx>, Carlos Maiolino <cmaiolino@xxxxxxxxxx>, xfs@xxxxxxxxxxx |
| In-reply-to: | <1320256339.3145.30.camel@doink> |
| References: | <1320156842.30281.28.camel@deadeye> <1320256339.3145.30.camel@doink> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
We should validate that the value isn't negative in xfs_iformat_*, although we currently don't do that. It already verified that it fits into the XFS_DFORK_DSIZE, which should take care of fitting into 32-bits. Adding another explicit check probably won't hurt, given that XFS_DFORK_DSIZE is calculated dynamically based on the fork offset. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | world wide gaming even when you lose you win, admin |
|---|---|
| Next by Date: | Re: [PATCH 7/8] xfstests: add a new test that runs fsstress under ENOSPC conditions, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH] Fix possible memory corruption in xfs_readlink, Alex Elder |
| Next by Thread: | Re: [PATCH] Fix possible memory corruption in xfs_readlink, Alex Elder |
| Indexes: | [Date] [Thread] [Top] [All Lists] |