| To: | Boris Ranto <branto@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfstests 016: Do not discard blocks at the mkfs time, more verbose version |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Fri, 28 Oct 2011 05:53:54 -0400 |
| Cc: | xfs <xfs@xxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Eric Sandeen <esandeen@xxxxxxxxxx> |
| In-reply-to: | <be02ada1-aee5-406d-84cd-d54dde7ae871@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
| References: | <1319625983.3074.28.camel@xxxxxxxxxxxxxxxxxxxxxxxxxx> <be02ada1-aee5-406d-84cd-d54dde7ae871@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Fri, Oct 28, 2011 at 05:38:06AM -0400, Boris Ranto wrote: > The test 016 fills scratch device with some data and then creates xfs fs > on the scratch device. Later, the test assumes that the previously > written data are still written there and checks for them at specific > locations. On ssd drive this will lead to a failure since the blocks are > discarded by default when the mkfs command is run. > This is a more verbose version of the previous patch. > This simple patch that adds -K to stop the discarding (if the mkfs > command supports it) fixed the issue for me: > > Signed-off-by: Boris Ranto <branto@xxxxxxxxxx> Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] xfstests 016: Do not discard blocks at the mkfs time, more verbose version, Boris Ranto |
|---|---|
| Next by Date: | [PATCH 00/45] write back all metadata via the AIL (and remove xfsbufd), Christoph Hellwig |
| Previous by Thread: | [PATCH] xfstests 016: Do not discard blocks at the mkfs time, more verbose version, Boris Ranto |
| Next by Thread: | [RFC v2 PATCH 0/5] xfs: Allow pquota and gquota to be used together, Chandra Seetharaman |
| Indexes: | [Date] [Thread] [Top] [All Lists] |