| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/4] xfs: force the log if we encounter pinned buffers in .iop_pushbuf |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Mon, 10 Oct 2011 12:39:29 +1100 |
| Cc: | xfs@xxxxxxxxxxx, Stefan Priebe <s.priebe@xxxxxxxxxxxx> |
| In-reply-to: | <20111006183549.598050900@xxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20111006183257.036884724@xxxxxxxxxxxxxxxxxxxxxx> <20111006183549.598050900@xxxxxxxxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Thu, Oct 06, 2011 at 02:32:59PM -0400, Christoph Hellwig wrote: > We need to check for pinned buffers even in .iop_pushbuf given that inode > items flush into the same buffers that may be pinned directly due operations > on the unlinked inode list operating directly on buffers. To do this add a > return value to .iop_pushbuf that tells the AIL push about this and use > the existing log force mechanisms to unpin it. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > Reported-by: Stefan Priebe <s.priebe@xxxxxxxxxxxx> > Tested-by: Stefan Priebe <s.priebe@xxxxxxxxxxxx> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| Previous by Date: | Re: [PATCH 1/4] xfs: do not update xa_last_pushed_lsn for locked items, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 3/4] xfs: revert to using a kthread for AIL pushing, Dave Chinner |
| Previous by Thread: | Re: [PATCH 2/4] xfs: force the log if we encounter pinned buffers in .iop_pushbuf, Alex Elder |
| Next by Thread: | [PATCH 4/4] xfs: add AIL pushing tracepoints, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |