xfs
[Top] [All Lists]

Re: [PATCH 6/9] xfs: clean up buffer allocation

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 6/9] xfs: clean up buffer allocation
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 7 Oct 2011 12:48:12 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20111006210639.521140680@xxxxxxxxxxxxxxxxxxxxxx>
References: <20111006210607.175284390@xxxxxxxxxxxxxxxxxxxxxx> <20111006210639.521140680@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Oct 06, 2011 at 05:06:13PM -0400, Christoph Hellwig wrote:
> Change _xfs_buf_initialize to allocate the buffer directly and rename it to
> xfs_buf_alloc now that is the only buffer allocation routine.  Also remove
> the xfs_buf_deallocate wrapper around the kmem_zone_free calls for buffers.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Cleans up the flow of the code quite a bit. Nice.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>