Re: [PATCH 23/27] rearrange bmapi and bmalloca structures for best packi

xfs

Re: [PATCH 23/27] rearrange bmapi and bmalloca structures for best packi

To:	Alex Elder <aelder@xxxxxxx>
Subject:	Re: [PATCH 23/27] rearrange bmapi and bmalloca structures for best packing
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Wed, 21 Sep 2011 10:06:03 -0400
Cc:	Christoph Hellwig <hch@xxxxxxxxxxxxx>, Dave Chinner <dchinner@xxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to:	<1316447547.2941.7.camel@doink>
References:	<20110918204040.266805129@xxxxxxxxxxxxxxxxxxxxxx> <20110918204147.015140236@xxxxxxxxxxxxxxxxxxxxxx> <1316447547.2941.7.camel@doink>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Mon, Sep 19, 2011 at 10:52:27AM -0500, Alex Elder wrote:
> On Sun, 2011-09-18 at 16:41 -0400, Christoph Hellwig wrote:
> > plain text document attachment (xfs-bmalloca-shrink)
> > Minimise the stack overhead of the remaining stack variables and
> > structures placed on the stack by packing them without holes. pahole
> > is used to optimise allocation args structures, stack variables are
> > done manually.
> > 
> > [hch: various updates while forward porting the changes]
> > 
> > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> I don't object to it, but I do comment on something
> below that I think is not an improvement.  I'll
> take this as-is anyway, unless you care to re-submit
> it.

This one actually breaks test 170, so I'd suggest skipping it for now.
All the later patches will apply just fine without it.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 05/27] xfs: introduce xfs_bmapi_read(), (continued) [PATCH 05/27] xfs: introduce xfs_bmapi_read(), Christoph Hellwig [PATCH 08/27] xfs: introduce xfs_bmapi_delay(), Christoph Hellwig [PATCH 10/27] xfs: factor extent allocation out of xfs_bmapi, Christoph Hellwig [PATCH 19/27] xfs: do not keep local copies of allocation ranges in xfs_bmapi_allocate, Christoph Hellwig [PATCH 15/27] xfs: pass bmalloca structure to xfs_bmap_isaeof, Christoph Hellwig [PATCH 22/27] xfs: move logflags into bmalloca, Christoph Hellwig [PATCH 16/27] xfs: move extent records into bmalloca structure, Christoph Hellwig [PATCH 12/27] xfs: rename xfs_bmapi to xfs_bmapi_write, Christoph Hellwig [PATCH 23/27] rearrange bmapi and bmalloca structures for best packing, Christoph Hellwig Re: [PATCH 23/27] rearrange bmapi and bmalloca structures for best packing, Alex Elder Re: [PATCH 23/27] rearrange bmapi and bmalloca structures for best packing, Christoph Hellwig <= Re: [PATCH 23/27] rearrange bmapi and bmalloca structures for best packing, Alex Elder [PATCH 20/27] xfs: move btree cursor into bmalloca, Christoph Hellwig [PATCH 21/27] xfs: move lastx and nallocs into bmalloca, Christoph Hellwig [PATCH 14/27] xfs: remove xfs_bmap_add_extent, Christoph Hellwig [PATCH 25/27] xfs: pass bmalloca to xfs_bmap_add_extent_hole_real, Christoph Hellwig [PATCH 17/27] xfs: move firstblock and bmap freelist cursor into bmalloca structure, Christoph Hellwig [PATCH 18/27] xfs: rename allocation range fields in struct xfs_bmalloca, Christoph Hellwig [PATCH 26/27] xfs: dont ignore error code from xfs_bmbt_update, Christoph Hellwig [PATCH 24/27] xfs: pass bmalloca to xfs_bmap_add_extent_delay_real, Christoph Hellwig [PATCH 27/27] xfs: cleanup xfs_bmap.h, Christoph Hellwig

Previous by Date:	Re: [patch 1/4] mm: exclude reserved pages from dirtyable memory, Mel Gorman
Next by Date:	Re: [patch 3/4] mm: filemap: pass __GFP_WRITE from grab_cache_page_write_begin(), Johannes Weiner
Previous by Thread:	Re: [PATCH 23/27] rearrange bmapi and bmalloca structures for best packing, Alex Elder
Next by Thread:	Re: [PATCH 23/27] rearrange bmapi and bmalloca structures for best packing, Alex Elder
Indexes:	[Date] [Thread] [Top] [All Lists]