Re: [PATCH] Return -EIO when xfs_vn

xfs

Re: [PATCH] Return -EIO when xfs_vn_getattr() failed

To:	Mitsuo Hayasaka <mitsuo.hayasaka.hu@xxxxxxxxxxx>
Subject:	Re: [PATCH] Return -EIO when xfs_vn_getattr() failed
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Sun, 18 Sep 2011 15:59:57 -0400
Cc:	Alex Elder <aelder@xxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, yrl.pp-manager.tt@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, xfs-masters@xxxxxxxxxxx
In-reply-to:	<20110917133838.27791.63070.stgit@xxxxxxxxxxxxxxxxxxxxxxxx>
References:	<20110917133838.27791.63070.stgit@xxxxxxxxxxxxxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Sat, Sep 17, 2011 at 10:38:38PM +0900, Mitsuo Hayasaka wrote:
> An attribute of inode can be fetched via xfs_vn_getattr() in XFS.
> Currently it returns EIO, not negative value, when it failed.
> As a result, the system call returns not negative value even though
> an error occured. The stat(2), ls and mv commands cannot handle this
> error and do not work correctly.
> 
> This patch fixes this bug, and returns -EIO, not EIO when an error
> is detected in xfs_vn_getattr().

Indeed.  Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] Return -EIO when xfs_vn_getattr() failed, Mitsuo Hayasaka Re: [PATCH] Return -EIO when xfs_vn_getattr() failed, Christoph Hellwig <= Re: [PATCH] Return -EIO when xfs_vn_getattr() failed, Alex Elder

Previous by Date:	[PATCH 2/2] xfstest: fsstress add EXT2_IOC_{SET,GET}FLAGS operations, Dmitry Monakhov
Next by Date:	Re: [PATCH 2/2] xfstest: fsstress add EXT2_IOC_{SET,GET}FLAGS operations, Christoph Hellwig
Previous by Thread:	[PATCH] Return -EIO when xfs_vn_getattr() failed, Mitsuo Hayasaka
Next by Thread:	Re: [PATCH] Return -EIO when xfs_vn_getattr() failed, Alex Elder
Indexes:	[Date] [Thread] [Top] [All Lists]