| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/2] xfs: fix xfs_mark_inode_dirty during umount |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Tue, 30 Aug 2011 03:27:21 -0400 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx |
| In-reply-to: | <20110830072013.GS3162@dastard> |
| References: | <20110827055731.GA24159@xxxxxxxxxxxxx> <20110827055744.GA28351@xxxxxxxxxxxxx> <20110830062416.GN3162@dastard> <20110830063949.GA19262@xxxxxxxxxxxxx> <20110830072013.GS3162@dastard> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Aug 30, 2011 at 05:20:13PM +1000, Dave Chinner wrote: > Now that may have been true on Irix/MIPS which had strong memory > ordering so only compiler barriers were necessary. > > However, normally when we talk about ordered memory semantics in > Linux, we cannot assume strong ordering - if we have ordering > requirements, we have to guarantee ordering by explicit use of > memory barriers, right? Probably. But I'm not worried about that so much, it's just timestamps we're talking about as the size already has the ilock unlock as full barrier, and we're going to kill this code soon anyway. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 1/2] xfs: fix xfs_mark_inode_dirty during umount, Dave Chinner |
|---|---|
| Next by Date: | Re: xfs_repair: add printf format checking and fix the fallout, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH 1/2] xfs: fix xfs_mark_inode_dirty during umount, Dave Chinner |
| Next by Thread: | Re: [PATCH 1/2] xfs: fix xfs_mark_inode_dirty during umount, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |