| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs: avoid synchronous transactions when deleting attr blocks |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Tue, 30 Aug 2011 16:30:35 +1000 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20110827144511.GB16381@xxxxxxxxxxxxx> |
| References: | <20110827144511.GB16381@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Sat, Aug 27, 2011 at 10:45:11AM -0400, Christoph Hellwig wrote: > Currently xfs_attr_inactive causes a synchronous transactions if we are > removing a file that has any extents allocated to the attribute fork, and > thus makes XFS extremely slow at removing files with out of line extended > attributes. The code looks a like a relict from the days before the busy > extent list, but with the busy extent list we avoid reusing data and attr > extents that have been freed but not commited yet, so this code is just > as superflous as the synchronous transactions for data blocks. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > Reported-by: Bernd Schubert <bernd.schubert@xxxxxxxxxxxxxxxxxx> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfs: avoid direct I/O write vs buffered I/O race, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 1/2] xfs: fix xfs_mark_inode_dirty during umount, Christoph Hellwig |
| Previous by Thread: | [PATCH] xfs: avoid synchronous transactions when deleting attr blocks, Christoph Hellwig |
| Next by Thread: | [PATCH] xfstests: don't print "do not support" warnings unless verbose is specified, Theodore Ts'o |
| Indexes: | [Date] [Thread] [Top] [All Lists] |