| To: | Alex Elder <aelder@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/3] xfsprogs: xfs_quota: don't double project block counts |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Thu, 25 Aug 2011 01:01:18 -0400 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <e874ff01906d10e2ff4812b6badcc246f6a43af4.1314222483.git.aelder@xxxxxxx> |
| References: | <adcfe5e08d1c060ea95a8aa43e1abade24957dd0.1314222483.git.aelder@xxxxxxx> <e874ff01906d10e2ff4812b6badcc246f6a43af4.1314222483.git.aelder@xxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Wed, Aug 24, 2011 at 04:53:42PM -0500, Alex Elder wrote: > In projects_free_space_data() all of the block counts returned are > doubled. This was probably a mistaken attempt to convert to or from > 512-byte basic block units. The caller expects the value returned > to be in 512-byte units, which is exactly what the fs_disk_quota > structure holds, so there should be no doubling. > > The effect of this bug is that the disk space used by the "df" > xfs_quota command shows block counts twice what they should be. > > SGI PV 1015651 > > Signed-off-by: Alex Elder <aelder@xxxxxxx> Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 1/3] xfsprogs: xfs_quota: return real-time used data as intended, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 3/3] xfsprogs: xfs_quota: improve calculation for percentage display, Christoph Hellwig |
| Previous by Thread: | [PATCH 2/3] xfsprogs: xfs_quota: don't double project block counts, Alex Elder |
| Next by Thread: | Re: [PATCH 1/3] xfsprogs: xfs_quota: return real-time used data as intended, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |