Re: [PATCH 08/11] xfs: defer AIO/DIO completions

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 08/11] xfs: defer AIO/DIO completions
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Wed, 24 Aug 2011 10:01:26 +1000
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20110823082913.270459702@xxxxxxxxxxxxxxxxxxxxxx>
References:	<20110823082802.335389799@xxxxxxxxxxxxxxxxxxxxxx> <20110823082913.270459702@xxxxxxxxxxxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Tue, Aug 23, 2011 at 04:28:10AM -0400, Christoph Hellwig wrote:
> We really shouldn't complete AIO or DIO requests until we have finished
> the unwritten extent conversion and size update.  This means fsync never
> has to pick up any ioends as all work has been completed when signalling
> I/O completion.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Much nicer ;)

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 00/11] patch queue for Linux 3.2, Christoph Hellwig [PATCH 01/11] xfs: remove delwri buffer handling from xfs_buf_iorequest, Christoph Hellwig [PATCH 02/11] xfs: remove the unlock argument to xfs_buf_delwri_queue, Christoph Hellwig [PATCH 03/11] xfs: move more delwri setup into xfs_buf_delwri_queue, Christoph Hellwig [PATCH 07/11] xfs: remove dead ENODEV handling in xfs_destroy_ioend, Christoph Hellwig [PATCH 06/11] xfs: use the "delwri" terminology consistently, Christoph Hellwig [PATCH 10/11] xfs: wait for I/O completion when writing out pages in xfs_setattr_size, Christoph Hellwig [PATCH 05/11] xfs: let xfs_bwrite callers handle the xfs_buf_relse, Christoph Hellwig [PATCH 09/11] xfs: reduce ioend latency, Christoph Hellwig [PATCH 08/11] xfs: defer AIO/DIO completions, Christoph Hellwig Re: [PATCH 08/11] xfs: defer AIO/DIO completions, Dave Chinner <= [PATCH 04/11] xfs: call xfs_buf_delwri_queue directly, Christoph Hellwig [PATCH 11/11] xfs: remove i_iocount, Christoph Hellwig

Previous by Date:	Re: [GIT PULL] XFS update for 3.1-rc4, Alex Elder
Next by Date:	Re: [GIT PULL] XFS update for 3.1-rc4, Dave Chinner
Previous by Thread:	[PATCH 08/11] xfs: defer AIO/DIO completions, Christoph Hellwig
Next by Thread:	[PATCH 04/11] xfs: call xfs_buf_delwri_queue directly, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]