| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 5/5] xfs: remove i_iocount |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Mon, 22 Aug 2011 16:46:41 +1000 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20110814222518.371157499@xxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20110814222412.359079843@xxxxxxxxxxxxxxxxxxxxxx> <20110814222518.371157499@xxxxxxxxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Sun, Aug 14, 2011 at 06:24:17PM -0400, Christoph Hellwig wrote: > We now have an i_dio_count filed and surrounding infrastructure to wait > for direct I/O completion instead of i_icount, and we have never needed > to iocount waits for buffered I/O given that we only set the page uptodate > after finishing all required work. Thus remove i_iocount, and replace > the actually needed waits with calls to inode_dio_wait. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Looks sane. One less bit of XFS specific code. ;) Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 4/5] xfs: wait for I/O completion when writing out pages in xfs_setattr_size, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH] xfstests: fix loggen compile against recent xfsprogs headers, Dave Chinner |
| Previous by Thread: | [PATCH 5/5] xfs: remove i_iocount, Christoph Hellwig |
| Next by Thread: | [PATCH 4/5] xfs: wait for I/O completion when writing out pages in xfs_setattr_size, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |