Re: [PATCH 4/6] xfs: call xfs_buf_delwri

xfs

Re: [PATCH 4/6] xfs: call xfs_buf_delwri_queue directly

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 4/6] xfs: call xfs_buf_delwri_queue directly
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Mon, 22 Aug 2011 16:22:11 +1000
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20110814171652.350395176@xxxxxxxxxxxxxxxxxxxxxx>
References:	<20110814171517.174040686@xxxxxxxxxxxxxxxxxxxxxx> <20110814171652.350395176@xxxxxxxxxxxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Sun, Aug 14, 2011 at 01:15:21PM -0400, Christoph Hellwig wrote:
> Unify the ways we add buffers to the delwri queue by always calling
> xfs_buf_delwri_queue directly.  The xfs_bdwrite functions is removed and
> opencoded in its callers, and the two places setting XBF_DELWRI while a
> buffer is locked and expecting xfs_buf_unlock to pick it up are converted
> to call xfs_buf_delwri_queue directly, too.  Also replace the
> XFS_BUF_UNDELAYWRITE macro with direct calls to xfs_buf_delwri_dequeue
> to make the explicit queuing/dequeuing more obvious.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
-- 
Dave Chinner
david@xxxxxxxxxxxxx

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/6] delwri cleanups, Christoph Hellwig [PATCH 1/6] xfs: remove delwri buffer handling from xfs_buf_iorequest, Christoph Hellwig Re: [PATCH 1/6] xfs: remove delwri buffer handling from xfs_buf_iorequest, Dave Chinner [PATCH 4/6] xfs: call xfs_buf_delwri_queue directly, Christoph Hellwig Re: [PATCH 4/6] xfs: call xfs_buf_delwri_queue directly, Dave Chinner <= [PATCH 2/6] xfs: remove the unlock argument to xfs_buf_delwri_queue, Christoph Hellwig Re: [PATCH 2/6] xfs: remove the unlock argument to xfs_buf_delwri_queue, Dave Chinner [PATCH 5/6] xfs: let xfs_bwrite callers handle the xfs_buf_relse, Christoph Hellwig Re: [PATCH 5/6] xfs: let xfs_bwrite callers handle the xfs_buf_relse, Dave Chinner [PATCH 3/6] xfs: move more delwri setup into xfs_buf_delwri_queue, Christoph Hellwig Re: [PATCH 3/6] xfs: move more delwri setup into xfs_buf_delwri_queue, Dave Chinner [PATCH 6/6] xfs: use the "delwri" terminology consistently, Christoph Hellwig Re: [PATCH 6/6] xfs: use the "delwri" terminology consistently, Dave Chinner

Previous by Date:	Re: [PATCH 3/6] xfs: move more delwri setup into xfs_buf_delwri_queue, Dave Chinner
Next by Date:	Re: [PATCH 5/6] xfs: let xfs_bwrite callers handle the xfs_buf_relse, Dave Chinner
Previous by Thread:	[PATCH 4/6] xfs: call xfs_buf_delwri_queue directly, Christoph Hellwig
Next by Thread:	[PATCH 2/6] xfs: remove the unlock argument to xfs_buf_delwri_queue, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]