| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/6] xfs: remove delwri buffer handling from xfs_buf_iorequest |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Mon, 22 Aug 2011 16:09:50 +1000 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20110814171651.707270455@xxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20110814171517.174040686@xxxxxxxxxxxxxxxxxxxxxx> <20110814171651.707270455@xxxxxxxxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Sun, Aug 14, 2011 at 01:15:18PM -0400, Christoph Hellwig wrote: > We cannot ever reach xfs_buf_iorequest for a buffer with XBF_DELWRI set, > given that all write handlers make sure that the buffer is remove from > the delwri queue before, and we never do reads with the XBF_DELWRI flag > set (which the code would not handle correctly anyway). > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 1/4] fs: add SEEK_HOLE and SEEK_DATA flags, Sunil Mushran |
|---|---|
| Next by Date: | Re: [PATCH 2/6] xfs: remove the unlock argument to xfs_buf_delwri_queue, Dave Chinner |
| Previous by Thread: | [PATCH 1/6] xfs: remove delwri buffer handling from xfs_buf_iorequest, Christoph Hellwig |
| Next by Thread: | [PATCH 4/6] xfs: call xfs_buf_delwri_queue directly, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |