| To: | Stefan Behrens <sbehrens@xxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 3/4] xfstests: Add support for btrfs in 015 |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Thu, 28 Jul 2011 16:05:37 -0400 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx |
| In-reply-to: | <4E31A265.5050909@xxxxxxxxxxxxxxxx> |
| References: | <cover.1311776403.git.sbehrens@xxxxxxxxxxxxxxxx> <bebfc5c98e0fb878f55c1312d8750ce7b7f82e07.1311776403.git.sbehrens@xxxxxxxxxxxxxxxx> <20110728084756.GC3407@xxxxxxxxxxxxx> <4E31A265.5050909@xxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Thu, Jul 28, 2011 at 07:54:45PM +0200, Stefan Behrens wrote: > To add a 10% tolerance for btrfs was a bad idea. > Since the output of df(1) is not yet reliable on btrfs volumes while > data is not flushed to disk, the better implementation would be to > either let this test fail, or to force a flush to disk before taking > the output of df(1). > The latter is what I have implemented now. I don't think it's correct either. dellalloc blocks should be included in the statfs output, else it it is pretty pointless. Can you send the patch to make it generic without that adjustment for now. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 3/4] xfstests: Add support for btrfs in 015, Stefan Behrens |
|---|---|
| Next by Date: | Re: 2.6.xx: NFS: directory motion/cam2 contains a readdir loop, Trond Myklebust |
| Previous by Thread: | Re: [PATCH 3/4] xfstests: Add support for btrfs in 015, Stefan Behrens |
| Next by Thread: | "xfs: fix error handling for synchronous writes" revisited, Ajeet Yadav |
| Indexes: | [Date] [Thread] [Top] [All Lists] |